[Benchmark] Add benchmark functional test framework with Qwen3 test case#1145
Merged
Conversation
added 9 commits
March 11, 2026 16:10
Collaborator
|
I recommend you use AI to generate a more detailed PR description. |
added 5 commits
March 13, 2026 16:05
Darryl233
reviewed
Mar 17, 2026
Collaborator
There was a problem hiding this comment.
Different chips performance differently, so maybe it's better to distinguish the gold values of different chips
LiJunscs
pushed a commit
to LiJunscs/FlagScale
that referenced
this pull request
Apr 13, 2026
…ase (flagos-ai#1145) ### PR Category CICD ### PR Types New Features ### PR Description Add a benchmark functional test framework to the CI/CD pipeline, enabling automated detection of training performance regressions by comparing runtime metrics against baseline gold values. - Introduce dedicated benchmark workflow (`functional_tests_benchmark.yml`) with artifact download retry logic, environment auto-setup, benchmark log parsing, metrics upload to backend, and failure log archiving - Add `test_benchmark_equal` in `check_results.py` supporting two threshold types (`upper_bound` for elapsed time, `lower_bound` for throughput) with configurable tolerance and automatic warmup iteration skipping (first 5 iterations) - Add `parse_benchmark_output.py` to extract metrics from training logs into structured JSON and upload to the metrics backend for tracking - Register `benchmark` as a new task type in the test runner (`run_functional_tests.sh`), platform config loader (`load_platform_config.sh`), and platform definition (`cuda.yaml`) - Add Qwen3 tp2_pp2 as the first benchmark test case with gold values for elapsed time per iteration (ms) and throughput per GPU (TFLOP/s/GPU) at 10% tolerance - Integrate benchmark tests into `all_tests_common.yml` and re-enable inference/serve test checks in the completion gate --------- Co-authored-by: zihugithub <fbye@baai.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
CICD
PR Types
New Features
PR Description
Add a benchmark functional test framework to the CI/CD pipeline, enabling automated detection of training performance regressions by comparing runtime metrics against baseline gold values.
functional_tests_benchmark.yml) with artifact download retry logic, environment auto-setup, benchmark log parsing, metrics upload to backend, and failure log archivingtest_benchmark_equalincheck_results.pysupporting two threshold types (upper_boundfor elapsed time,lower_boundfor throughput) with configurable tolerance and automatic warmup iteration skipping (first 5 iterations)parse_benchmark_output.pyto extract metrics from training logs into structured JSON and upload to the metrics backend for trackingbenchmarkas a new task type in the test runner (run_functional_tests.sh), platform config loader (load_platform_config.sh), and platform definition (cuda.yaml)all_tests_common.ymland re-enable inference/serve test checks in the completion gate